[3/n] Refactor workflow details page to use v2 nodes route #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likawind
force-pushed
the
eng-2699-m1-refactor-wf-detail-pages-to-use-new-3
branch
from
4196cf7
to
80babf5
Compare
… eng-2699-m1-refactor-wf-detail-pages-to-use-new-3
… eng-2699-m1-refactor-wf-detail-pages-to-use-new-3
agiron123
reviewed
May 18, 2023
| (state: RootState) => state.nodeSelectionReducer.selected | ||
| const selectedNodeState = useSelector( | ||
| (state: RootState) => | ||
| state.workflowPageReducer.perWorkflowPageStates[workflowId]?.SelectedNode |
There was a problem hiding this comment.
what does this perWorkflowPageStates do? Does it manage the sidesheet state?
There was a problem hiding this comment.
After getting deep into most refactors, I think the only thing it's managing is the selected node (which controls whether to show and which sidesheet to show). It doesn't further manage any page states, which will be controlled by page components or already handled by RTK
agiron123
approved these changes
May 18, 2023
likawind
commented
May 18, 2023
| @@ -120,6 +120,7 @@ func NewArtifactFromDBObject(dbArtifactNode *views.ArtifactNode) *Artifact { | |||
| type ArtifactResult struct { | |||
| // Contains only the `result`. It mostly mirrors 'artifact_result' schema. | |||
| ID uuid.UUID `json:"id"` | |||
| ArtifactID uuid.UUID `json:"artifact_id"` | |||
agiron123
approved these changes
May 18, 2023
… eng-2699-m1-refactor-wf-detail-pages-to-use-new-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR refactors workflow details page to use v2 nodes route. We mainly handle node selection and retrieval logic to directly use
nodesfrom V2 endpoints, rather than the convolutedoperatorsandartifactsobjects inselectedDagreducer state.We are not yet touching the node rendering part, which is a huge change and will include in a separate PR.
Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)