Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable on demand GPU scheduling support for GKE #1407

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

jpurusho65
Copy link
Contributor

@jpurusho65 jpurusho65 commented Jun 4, 2023

Describe your changes and why you are making these changes

  1. Add new resource providers
  2. Add additional oauth scope to fetch nvidia drivers
  3. Add the latest nvidia COS driver plugin terraform script

Related issue number (if any)

ENG-3066

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • [x ] I have performed a self-review of my code.
  • [x ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • [x ] I have run the integration tests locally and they are passing.
  • [x ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [x ] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@jpurusho65
Copy link
Contributor Author

Screen Shot 2023-06-04 at 15 27 42 PM
Screen Shot 2023-06-04 at 15 33 23 PM

@jpurusho65 jpurusho65 requested a review from cw75 June 4, 2023 22:39
@jpurusho65 jpurusho65 force-pushed the eng-3066-implement-gpu-support-for-ondemand-gke branch from a8adc34 to a0c1b6a Compare June 4, 2023 23:10
src/terraform/gke/variables.tf Outdated Show resolved Hide resolved
src/terraform/gke/variables.tf Outdated Show resolved Hide resolved
@jpurusho65 jpurusho65 force-pushed the eng-3066-implement-gpu-support-for-ondemand-gke branch from a0c1b6a to 247c1a3 Compare June 6, 2023 00:18
@jpurusho65 jpurusho65 requested a review from cw75 June 6, 2023 01:12
1. Add new resource providers
2. Add additional oauth scope to fetch nvidia drivers
3. Add the latest nvidia COS driver plugin terraform script
@jpurusho65 jpurusho65 force-pushed the eng-3066-implement-gpu-support-for-ondemand-gke branch from 247c1a3 to afa9edd Compare June 6, 2023 02:55
Copy link
Contributor

@cw75 cw75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpurusho65 jpurusho65 added the run_integration_test Triggers integration tests label Jun 6, 2023
@jpurusho65 jpurusho65 merged commit ca3b9c0 into main Jun 6, 2023
@jpurusho65 jpurusho65 deleted the eng-3066-implement-gpu-support-for-ondemand-gke branch June 6, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants