v4.31.0 #1224

Cabecinha84 · 2024-02-17T10:49:52Z

Backup/Restore Container Data -> It is now possible to backup your application container data and restore it. The new feature is now available under local apps management;
Improvements on Syncthing;
FluxOs UI colors/icons updates;
Other small improvements.

* UI correction and build * added custom-butto and build UI * Build UI * button correction * button correction * UI build * UI build * Build UI * UI build test * Fix applyFilter and UI build * UI tweaks * UI correction and build * added backupRestoreService * Initial * Build UI * added missing bootstrap-vue components * added missing bootstrap components * Build UI * fix BootstrapVueIcons * fix restore table and icons * Build UI * UI corrections * Build UI * UI correction and build * UI correction and build * UI correction and build * added custom-butto and build UI * Build UI * button correction * UI build * added backupRestoreService * Merge branch 'appbackuprestore' of https://github.com/RunOnFlux/flux into appbackuprestore * Revert corrupted merges * merge dev to appbackuprestore (#1200) * fix apps having one less instance running than specified * clean up code * patch to not use new sign mechanism until tuesday release * Rebuild HomeUI * Bump Version * make extendSubscription default to true * fix UI build * revert ui elements from development * getAvailableSpaceOfApp UI implementation * fix params check * fix df * added getRemoteFileSize and UI Integration * added missing route * add encodeURIComponent and logs * checkRemoteFileSize correction * add logs removed type check * getRemoteFileSize correction * added multiplier and decimal for getavailablespaceofapp * added getComponentPath * fix * fix * fix function * fix precision * function rename * fix getcomponentstoragespace * added getVolumeDataOfComponent * add logs * fix fields variable * cleanup * flx decimal * added separate function dfInfo * added comments , init getRemoteFile * getRemoteFile test * add logs * added JSON.stringify * getRemoteFile test * added missing mount * added getRemoteFile * fix path * added checkFileExists, removeFile * test * added getPathFileList * added filterKeywords for getPathFileList * fileInfo correction * getBackupleList test * test * add logs * add more logs * more logs * added more logs * added more logs * add more logs * fix filter * added removeBackupFile, improved formatDateTime * added logs * removed cache * disabled removeAppLocally * disabled removeAppLocally * removed removeAppLocally * added downloadLocalBackup * fixed downloadBackupFile and other improvements * split and improved function - IOService created * added logs * fix getRemoteFileSize * fix typo * lib rename * [WIP] tarDirectory, appendBackupTask, added backupCheck in syncthingApps * clean style * clean * [WIP] tarDirectory, update backend * test * fix tarDirectory * fix test * fix tar * test * fs fix * [ADD] untarFile, createTarGz, removeDirectory, getFileSize, appendBackupTask * Changed operation order * [ADD] getFolderSize * [FIX] appendbackuptask route * [FIX] appendBackupTask * [ADD] logs * [ADD] more logs * more logs * test * more logs * more logs * [FIX] appendBackupTask * [FIX] existStatus * add more logs * [FIX] backapSize * add logs * [FIX] skip * [FIX] backupSize on UI * fix skip * [FIX] createTarGz * [ADD] stop, start docker via UI, backup progress * [FIX] createBackup UI * [ADD] comments for functions in IOUtils, improve getVolumeInfo and removeDirectory * Build UI * change some text descriptions and typos * fix table column description * [UPDATE] rework post call, update formidable, init fileUpload * test * test * test * revert * revert formidable version * add logs * revert fluxShareUpload * add logs * more logs * test * test * fluxShare improvement * fix folder and rever update * fix filepath * fix filename functuin, cleanup * [FIX] removeDirectory, add fluxshare ability to remove not empty directory * Remove unused part of code * [WIP] Finalizing Upload File UI for restore section, other minor edits * [WIP] convertFileSize - added auto conversion, finalizing fileUpload * convertFileSize global correction * [ADD] bytes support for getVolumeInfo * [ADD] option for convertFileSize to return number only * [ADD] number arg for functions releted with convertFileSize * fix getVolumeInfo * [FIX] getVolumeInfo output * [FIX] file.filepath in fileUpload * getFolderSize and getFileSize return in bytes * [WIP] appendRestoreTask * appDockerStart correction * [ADD] sendChunk, backupPathValidation, improved appendRestoreTask * [FIX] restoreDirectory , finalizing appendRestoreTask * Minor edits * [FIX] untarFile, createTarGz * removed tar lib , eslint correction * appendBackupTask function rewrite, UI correction * [ADD] Skip check in checkAndNotifyPeersOfRunningApps * Minor edit * Finalizing appendBackupTask, appendRestoreTask * [ADD] more logs * [FIX] appendRestoreTask * Cleanup * [ADD] pathValidation for backupRestoreService API * [ADD] comments for backupRestoreService functions * Code cleanup * changed operation order in appendRestoreTask * Better error handling * pathValidation correction * Dont delete receiveOnlySyncthingAppsCache on backup and restore process * UI tweaks * removed setTimeout after restore * fix typo * Fix typo * Upload UI error handling * moved pathValidation after auth * UI Tweks * fix typo * fix typo * processChunks optimization * Cleanup, fix typo * Minor edits * Removed hover for Remote URL and Upload File * Minor edits * updateManagementTab correction * [ADD] Interactive Terminal custom user, UI Tweaks * [FIX] configReload * [ADD] User info on Interactive Terminal UI * move syncthing check for backend and adjust solution based on syncthing type. * don't hard redeploy node after restore if it is using syncthing * clean up * fix catch on different situations * only for apps version > 3 * only restart syncthing if needed * rebuild homeUI * fix log type * log appDetails * fix * fix * just sync appdata folder * [ADD] Upload progress info * [ADD] Prevent size text wrapping in table * Fix syncthing and don't sync backup folder of fluxos * fix Privilege * changed privilage * Remove backup archive after success unpack * fix permission * rebuild homeUI * fix missing appname * fix download progress * changed delay * removed logs * Minor edit * Build UI * [ADD] Better error handle for createTarGz * [ADD] cmdGetWithMaxBuffer * [ADD] remote directory cleanup, UI tweaks * rebuild UI * [ADD] runCommand with stdout, stderr * [ADD] Better error handle for tar operation, fix upload filename * clean up * Build UI * Catch only main error * Build UI * [ADD] keep-alive header * [ADD] fetch Connection header, removed setHeader * Build UI * after redeploy start docker even for g syncthing, other nodes will start with delay * dont execute masterSlaveApps for apps executing backup/restore * Moved b-alert inside tab area * Build UI * revert removeAppLocally * removed nodecmd from IOUtils.js --------- Co-authored-by: Cabecinha84 <valter.cabecinha@gmail.com> Co-authored-by: Cabecinha84 <42519726+Cabecinha84@users.noreply.github.com>

…development

gitguardian · 2024-02-17T10:50:38Z

⚠️ GitGuardian has uncovered 18 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9015359	Triggered	PGP Private Key	`6fd3af5`	HomeUI/dist/js/index.js	View secret
9015359	Triggered	PGP Private Key	`ff0b300`	HomeUI/dist/js/index.js	View secret
9015359	Triggered	PGP Private Key	`5155e2b`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`ff0b300`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`6fd3af5`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`5155e2b`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`7241b34`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`8429288`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`8429288`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e97672d`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e97672d`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`2659e31`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`7241b34`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`2659e31`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`ce6327e`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`ce6327e`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`8fbfecd`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`8fbfecd`	HomeUI/dist/js/index.js	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

codecov · 2024-02-17T11:01:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9ffa8f) 50.12% compared to head (8fbfecd) 48.49%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   50.12%   48.49%   -1.63%     
==========================================
  Files          43       45       +2     
  Lines       14241    14796     +555     
==========================================
+ Hits         7138     7176      +38     
- Misses       7103     7620     +517

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TheTrunk

4 tests are now failing
Missing entire test suite for IOutils
Missing tests for new functions, adjusted functions.
Version bump is missing

TheTrunk · 2024-02-19T02:24:57Z

ZelBack/src/services/fluxshareService.js

@@ -546,8 +547,8 @@ async function fluxShareRemoveFolder(req, res) {

      const dirpath = path.join(__dirname, '../../../');
      const filepath = `${dirpath}ZelApps/ZelShare/${folder}`;
-      await fs.promises.rmdir(filepath);
-
+      // await fs.promises.rmdir(filepath);


why are we not using fs for it? instead of it it executes sudo rm -rf.

fs.promises.rmdir will not remove not empty dir i want give ability to remove directory with files and others directory

You can actually achieve that using FS module as its described in the docs
https://nodejs.org/api/fs.html#fspromisesrmdirpath-options

but it will not solve situation when i want remove all files and folders but i want keep main directory ( or i miss something)

From docs:

To get a behavior similar to the rm -rf Unix command, use fsPromises.rm() with options { recursive: true, force: true }.

The rmdir recursive is depreciated

TheTrunk · 2024-02-19T02:25:15Z

ZelBack/src/services/IOUtils.js

+ * @param {boolean} directory - Flag indicating whether to remove only the directory contents (true) or the entire directory (false).
+ * @returns {boolean} - True if the directory or its contents are removed successfully, false on failure.
+ */
+async function removeDirectory(rpath, directory = false) {


why not using fs module?

fs.promises.rmdir will not remove not empty dir i want give ability to remove directory with files and others directory

package.json

ZelBack/src/lib/socket.js

ZelBack/src/lib/server.js

XK4MiLX and others added 23 commits February 14, 2024 11:08

Fix and rebuild HomeUI

ff0b300

mark app as restarted for syncthingApps and masterSlave function

c7a4a2d

fix responseType

e794f17

Build UI

6fd3af5

fix masterSlaveApps

c164ff7

removed error line break in createTarGz, untarFile

df2f515

[ADD] application/json header

4a837e2

Change description on UI

5155e2b

removed setHeader

0284b8b

Revert post parse

fb7cdbc

[FIX] fluxShareUpload path

ccdbe69

[FIX] idService

463cd08

Disable urlencoded

d3eb347

[FIX] appendBackupTask and appendRestoreTask

3847f09

[FIX] Backup Api

9cc7412

fluxify

62f596d

Make user buy app on marketplace

7a21c89

light mode ssp icon

1a276e2

Merge branch 'development' of https://github.com/RunOnFlux/flux into …

03f98f7

…development

rebuild homeUI

8429288

Fix calculation

7984bfa

Rebuild UI

7241b34

Cabecinha84 requested review from alihm, TheTrunk and XK4MiLX February 17, 2024 10:49

revert change

7074ad3

Cabecinha84 temporarily deployed to github-pages February 17, 2024 10:55 — with GitHub Pages Inactive

change from new Date().getTime() to Date.now()

2659e31

Cabecinha84 temporarily deployed to github-pages February 17, 2024 11:22 — with GitHub Pages Inactive

Fix typo

e97672d

Cabecinha84 temporarily deployed to github-pages February 17, 2024 11:34 — with GitHub Pages Inactive

validate timsetamp of the message for the appregister and appupdate

2b7d758

Cabecinha84 temporarily deployed to github-pages February 17, 2024 12:58 — with GitHub Pages Inactive

add 5m buffer to future times

d56a814

Cabecinha84 temporarily deployed to github-pages February 17, 2024 13:05 — with GitHub Pages Inactive

TheTrunk requested changes Feb 19, 2024

View reviewed changes

update enterprise keys

f029d9e

TheTrunk temporarily deployed to github-pages February 19, 2024 02:54 — with GitHub Pages Inactive

removed unused module

b570c84

XK4MiLX temporarily deployed to github-pages February 19, 2024 07:29 — with GitHub Pages Inactive

removed body-parser

5974ddc

XK4MiLX temporarily deployed to github-pages February 19, 2024 07:30 — with GitHub Pages Inactive

start using flux storage for messages long to sign on zelcore

ce6327e

Cabecinha84 temporarily deployed to github-pages February 19, 2024 11:20 — with GitHub Pages Inactive

revert/fix unittests

128da27

Cabecinha84 temporarily deployed to github-pages February 19, 2024 11:52 — with GitHub Pages Inactive

Bump version

233bac6

Cabecinha84 temporarily deployed to github-pages February 19, 2024 12:01 — with GitHub Pages Inactive

[ADD] toLowerCase() for file archive

0229705

XK4MiLX temporarily deployed to github-pages February 19, 2024 14:13 — with GitHub Pages Inactive

remove await no longer needed

bdc2e2c

Cabecinha84 temporarily deployed to github-pages February 20, 2024 12:30 — with GitHub Pages Inactive

Fix refresh of Running Instances

8fbfecd

Cabecinha84 temporarily deployed to github-pages February 20, 2024 15:00 — with GitHub Pages Inactive

TheTrunk merged commit c95299e into master Feb 20, 2024
5 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v4.31.0 #1224

v4.31.0 #1224

Cabecinha84 commented Feb 17, 2024

gitguardian bot commented Feb 17, 2024 •

edited

Loading

codecov bot commented Feb 17, 2024 •

edited

Loading

TheTrunk left a comment •

edited

Loading

TheTrunk Feb 19, 2024

XK4MiLX Feb 19, 2024 •

edited

Loading

TheTrunk Feb 19, 2024

XK4MiLX Feb 19, 2024 •

edited

Loading

MorningLightMountain713 Feb 19, 2024 •

edited

Loading

MorningLightMountain713 Feb 19, 2024

TheTrunk Feb 19, 2024

XK4MiLX Feb 19, 2024

v4.31.0 #1224

v4.31.0 #1224

Conversation

Cabecinha84 commented Feb 17, 2024

gitguardian bot commented Feb 17, 2024 • edited Loading

⚠️ GitGuardian has uncovered 18 secrets following the scan of your pull request.

codecov bot commented Feb 17, 2024 • edited Loading

Codecov Report

TheTrunk left a comment • edited Loading

Choose a reason for hiding this comment

TheTrunk Feb 19, 2024

Choose a reason for hiding this comment

XK4MiLX Feb 19, 2024 • edited Loading

Choose a reason for hiding this comment

TheTrunk Feb 19, 2024

Choose a reason for hiding this comment

XK4MiLX Feb 19, 2024 • edited Loading

Choose a reason for hiding this comment

MorningLightMountain713 Feb 19, 2024 • edited Loading

Choose a reason for hiding this comment

MorningLightMountain713 Feb 19, 2024

Choose a reason for hiding this comment

TheTrunk Feb 19, 2024

Choose a reason for hiding this comment

XK4MiLX Feb 19, 2024

Choose a reason for hiding this comment

gitguardian bot commented Feb 17, 2024 •

edited

Loading

codecov bot commented Feb 17, 2024 •

edited

Loading

TheTrunk left a comment •

edited

Loading

XK4MiLX Feb 19, 2024 •

edited

Loading

XK4MiLX Feb 19, 2024 •

edited

Loading

MorningLightMountain713 Feb 19, 2024 •

edited

Loading