Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.33.0 #1244

Merged
merged 7 commits into from
Mar 5, 2024
Merged

V4.33.0 #1244

merged 7 commits into from
Mar 5, 2024

Conversation

Cabecinha84
Copy link
Member

UI optimizations.

Copy link

gitguardian bot commented Mar 5, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8398280 Triggered PGP Private Key ae7a9bb HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key ae7a9bb HomeUI/dist/js/index.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.48%. Comparing base (c413495) to head (b8eb1ce).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
+ Coverage   48.46%   48.48%   +0.02%     
==========================================
  Files          45       45              
  Lines       14925    14925              
==========================================
+ Hits         7234     7237       +3     
+ Misses       7691     7688       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTrunk TheTrunk merged commit 55f2d03 into master Mar 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants