v5.16.0 #1367

Cabecinha84 · 2024-07-08T12:41:04Z

New app registration flow, with a new test application feature. It's now mandatory to test apps before the payment, to make sure it will install/start on nodes;
The new test application feature is also available on app management on update/renew when app owner select to update app specifications;
Improvements on syncthing apps soft/hard redeploy. Apps using primary/standby, will show with status created on standby nodes;
OCI image support and image tests improvements;
Websocket connections refactor/improvements;
New checks to not allow the same collateral to be running on two different nodes at the same time;
Improve dynamic ip handling making the daemon get the new node ip faster;
Other small improvements.

…e where the app is already running

* Add OCI image support and imageVerifier class * Remove dead code, lint, fix up whitelist checker * Auth fix * Cosmetic fixes * Add missing return (doesn't change logic) * Fix bug where architecture wasn't being awaited * Check in tests I deleted by mistake * Patch imageVerifier to use serviceHelper axios * Fix tests to stub serviceHelper instead of axios * Fix global interceptor not working on axios instance * Fix axios instance missing baseUrl * Move repository check to the end of trySpawningGlobalApps * Fix appService integration tests * Fix issue where image manifest can be for arm64 by default * Remove whitelist validation * remove duplicate entry from repo (it's on master already) --------- Co-authored-by: Cabecinha84 <42519726+Cabecinha84@users.noreply.github.com>

* Test commit * first commit * Add socketserver * Sort out module require * Add debug * Listen on correct var * Add more debug * update url * set correct handler * Fix matcher * Remove config * Fix spread * move everything to fluxServer * set server * Add default error handler * Remove express-ws dep * Fix multiple socket.io listeners * Update notes * Start work on tests * More tests * Update tests * Fix integration tests * Remove debug log

* Remove version check * Update variable name

gitguardian · 2024-07-08T12:41:17Z

⚠️ GitGuardian has uncovered 25 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
8398280	Triggered	PGP Private Key	`312422a`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e05593f`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e05593f`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`bce55a5`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`1865123`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`7d088bf`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`312422a`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e3958b7`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`3b1627a`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`bce55a5`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`3b1627a`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e3958b7`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`1865123`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`7d088bf`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`ee26c29`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`ee26c29`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e6a842b`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`e6a842b`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`09a45d7`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`09a45d7`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`4ef1cd8`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`4ef1cd8`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`9456084`	HomeUI/dist/js/index.js	View secret
8398280	Triggered	PGP Private Key	`9456084`	HomeUI/dist/js/index.js	View secret
12978985	Triggered	Generic Private Key	`3109e8b`	tests/ZelBack/apiTests.js	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

Cabecinha84 and others added 26 commits July 3, 2024 17:14

do not start apps with r or g syncthing after soft or hard redeploy

4c1f6cc

on soft redeploy only g apps you don't want to start auto

45c9241

change wrong char with the correct one when copy paste is used

8495d9c

Refactor test functionality

805aa41

rebuild homeUI

ee26c29

add try catch

b4e7ba8

fix route and rebuild homeUI

e6a842b

add missing test check, rebuild ui

09a45d7

changed outputs on UI

3b1627a

update

da2850b

clear output when app specs are changed

4ef1cd8

change registration flow, test app install is now mandatory

63d4b67

rebuild homeui

312422a

test app install on updates

8c24b59

add test to appName as on updates the test might be launched on a nod…

adb2cb0

…e where the app is already running

rebuild homeUI

e05593f

Fix for ssl api server

ded8584

Add integration tests for flux https server

3109e8b

small UI change

1865123

Do not allow two ip's running on the network with same collateral.

0647f87

improve dynamic ip handling making the daemon get the new ip faster

de0ce37

bump version

e873270

Feature - Remove version check hack (#1366)

0fbe4f4

* Remove version check * Update variable name

rebuild UI

e3958b7

Cabecinha84 requested review from alihm, MorningLightMountain713, TheTrunk and XK4MiLX July 8, 2024 12:41

fix

06a1e8c

Cabecinha84 temporarily deployed to github-pages July 8, 2024 12:51 — with GitHub Pages Inactive

Apps can still be paid if failed

7d088bf

Cabecinha84 temporarily deployed to github-pages July 9, 2024 08:50 — with GitHub Pages Inactive

change warning message

bce55a5

Cabecinha84 temporarily deployed to github-pages July 9, 2024 09:02 — with GitHub Pages Inactive

create support team flux id

9456084

Cabecinha84 temporarily deployed to github-pages July 9, 2024 09:18 — with GitHub Pages Inactive

TheTrunk approved these changes Jul 9, 2024

View reviewed changes

TheTrunk merged commit f0446d4 into master Jul 9, 2024
4 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v5.16.0 #1367

v5.16.0 #1367

Cabecinha84 commented Jul 8, 2024

gitguardian bot commented Jul 8, 2024 •

edited

Loading

v5.16.0 #1367

v5.16.0 #1367

Conversation

Cabecinha84 commented Jul 8, 2024

gitguardian bot commented Jul 8, 2024 • edited Loading

⚠️ GitGuardian has uncovered 25 secrets following the scan of your pull request.

gitguardian bot commented Jul 8, 2024 •

edited

Loading