Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Python check endpoint #119

Merged

Conversation

ascholerChemeketa
Copy link
Contributor

Server endpoint to get pyflakes output from code sample

Question:
Are you happy with the endpoint being in /ns/books/?
Should it be in some new group? (/ns/utils/python_check/ or something like that)

Include non-syntax errors
Standardise message formats for syntax and other areas
@bnmnetp
Copy link
Member

bnmnetp commented Mar 22, 2023

when you asked before I was not thinking about this particular thing as having a home in books.
I am thinking that we might want to put this in its own file under routers. Maybe coach.py
/ns/coach/python_check ?

@ascholerChemeketa
Copy link
Contributor Author

Yes, that makes sense. Will move and update PR.

@ascholerChemeketa
Copy link
Contributor Author

Endpoint moved

@bnmnetp
Copy link
Member

bnmnetp commented Apr 1, 2023

@ascholerChemeketa Can you run black on coach.py please?

@bnmnetp
Copy link
Member

bnmnetp commented Apr 1, 2023

Nevermind, I can do it just as easy.

@bnmnetp bnmnetp merged commit 3cf0f0e into RunestoneInteractive:main Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants