Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary #include from rust-expr.h #3051

Closed
badumbatish opened this issue Jun 13, 2024 · 2 comments · Fixed by #3077
Closed

Remove unnecessary #include from rust-expr.h #3051

badumbatish opened this issue Jun 13, 2024 · 2 comments · Fixed by #3077
Labels
cleanup good-first-pr

Comments

@badumbatish
Copy link
Contributor

badumbatish commented Jun 13, 2024 •
edited
Loading

The file gcc/rust/ast/rust-expr.h has some dummy include line that would be perfect for newcomers to come and participate in open source.

Please remove these two lines in the file as follow, build and compile the code base to make sure every test passes and open a PR.

#include "rust-path.h"
#include "rust-macro.h"
#include "rust-operators.h"
- #include "rust-system.h"
- #include <memory>

Please preview the original issue inn #2982 (comment):

         ah, the system include is still here. you should be able to remove it entirely
@liamnaddell
Copy link
Contributor

Could I be assigned this? I made+tested the change on arm64, and can submit a PR.

@badumbatish
Copy link
Contributor Author

Hi @liamnaddell ! Yes please open a PR i can help with the review if needed

@liamnaddell liamnaddell mentioned this issue Jul 5, 2024
Merged
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 5, 2024
@liamnaddell
[Rust-GCC#3051] Remove unnecessary #include from rust-expr.h
aff889e 
Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 6, 2024
@liamnaddell
[Rust-GCC#3051] Remove unnecessary #include from rust-expr.h
9ec287f 
Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>

gcc/rust/ChangeLog:
	* ast/rust-expr.h:
	Remove unnecessary include
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 6, 2024
@liamnaddell
[Rust-GCC#3051] Remove unnecessary #include from rust-expr.h
82a7e09 
gcc/rust/ChangeLog:
	* ast/rust-expr.h:
	Remove unnecessary include

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 6, 2024
@liamnaddell
[Rust-GCC#3051] Remove unnecessary #include from rust-expr.h
19cc545 
gcc/rust/ChangeLog:
	* ast/rust-expr.h:
	Remove unnecessary include.

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 10, 2024
@liamnaddell
[Rust-GCC#3051] Remove unnecessary #include from rust-expr.h
f64c314 
gcc/rust/ChangeLog:
	* ast/rust-expr.h:
	Remove unnecessary include.

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
liamnaddell added a commit to liamnaddell/gccrs that referenced this issue Jul 11, 2024
@liamnaddell
[Rust-GCC#3051] Remove unnecessary #include from rust-expr.h
70f4db7 
gcc/rust/ChangeLog:
	* ast/rust-expr.h:
	Remove unnecessary include.

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
@liamnaddell @CohenArthur
[#3051] Remove unnecessary #include from rust-expr.h
d674058 
gcc/rust/ChangeLog:
	* ast/rust-expr.h:
	Remove unnecessary include.

Signed-off-by: Liam Naddell <liam.naddell@mail.utoronto.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good-first-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary #include from rust-expr.h liamnaddell/gccrs
3 participants
@liamnaddell @badumbatish @CohenArthur