ast: Add ResolveGenericArgs resolver #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
force-pushed
the
resolve-generic-args-resolver
branch
from
bec3bcd
to
8fe0536
Compare
Merged
philberty
approved these changes
Jul 6, 2022
|
bors r+ |
|
Merge conflict. |
CohenArthur
force-pushed
the
resolve-generic-args-resolver
branch
from
8fe0536
to
0da912f
Compare
|
bors r+ |
This resolver replaces the helper function `ResolveType::type_resolve_generic_args` and will later benefit from more functionality such as generic disambiguation
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jul 7, 2022
1355: Ambiguous generic arg r=CohenArthur a=CohenArthur Needs #1354. Only review the last commit :) ast: Rename ConstGenericArg -> GenericArg This makes the class clearer and exposes the fact that it may contain a type OR a const value clearer. Because we now run in ambiguous cases later in the compiler pipeline, this commit also adds horrible hacks to simply ignore ambiguous generic arguments and treat them as type arguments. Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolver replaces the helper function
ResolveType::type_resolve_generic_argsand will later benefit frommore functionality such as generic disambiguation