Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linemap to be optional nullptr #1364

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Allow linemap to be optional nullptr #1364

merged 1 commit into from
Jul 7, 2022

Conversation

philberty
Copy link
Member

The line map within the lexer is used to notify GCC of location data.
This lexer is used on raw string buffers where the linemap can be
null and thus can hit nullptr's. This patch wraps the linemap usage
behind a function. We might make the linemap mandatory as a reference
but lets figure out how the location info should look for imports first.

Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty
Copy link
Member Author

bors r+

@bors bors bot merged commit 98b3f9b into master Jul 7, 2022
@bors
Copy link
Contributor

bors bot commented Jul 7, 2022

Build succeeded:

@philberty philberty deleted the phil/linemap branch July 7, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants