Support aggregate types in transmute #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some testcases in libcore transmute is used on aggregate types like array's. The convert expression code assumes simple integer's. This this patch uses a gimple convert_expr to try and convert this type. This might change to a generic memcpy at somepoint but lets try this first and see how it works.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some testcases in libcore transmute is used on aggregate types like
array's. The convert expression code assumes simple integer's. This this
patch uses a gimple convert_expr to try and convert this type. This might
change to a generic memcpy at somepoint but lets try this first and see how
it works.