Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Items with Rust ABI need to mangle the full path #1387

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

philberty
Copy link
Member

When compiling external rust abi item requires the fully qualified
canonical path to be mangled in order to link correctly.

When compiling external rust abi item requires the fully qualified
canonical path to be mangled in order to link correctly.
@philberty philberty added the bug label Jul 15, 2022
@philberty philberty added this to the Imports and visibility milestone Jul 15, 2022
@philberty philberty self-assigned this Jul 15, 2022
@philberty
Copy link
Member Author

bors r+

@bjorn3
Copy link

bjorn3 commented Jul 15, 2022

#[no_mangle] is what determines if symbol mangling should happen, not the calling convention. You should mangle all functions not marked as #[no_mangle] and mangle all imported functions unless they are imported using an extern "..." { ... } block.

@bors
Copy link
Contributor

bors bot commented Jul 15, 2022

Build succeeded:

@bors bors bot merged commit 0a9416f into master Jul 15, 2022
@bjorn3
Copy link

bjorn3 commented Jul 15, 2022

@philberty

@philberty philberty deleted the phil/extern-rust-abi branch July 15, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants