Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic StackedContexts<T> type #1415

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Add generic StackedContexts<T> type #1415

merged 1 commit into from
Jul 28, 2022

Conversation

CohenArthur
Copy link
Member

No description provided.

@philberty philberty added this to the Const Generics milestone Jul 27, 2022
philberty
philberty approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Another nice thing we could do is like RAIIStackedContextGuard guard(stackedContext) so on the constructor we enter and on the destructor we exit.

@CohenArthur CohenArthur mentioned this pull request Jul 27, 2022
Merged
bors bot added a commit that referenced this pull request Jul 28, 2022
@bors @CohenArthur
Merge #1419
add0846 
1419: Const checker r=CohenArthur a=CohenArthur

This commit serves as a base to ensure that only the allowed subset of
the language is called from const contexts. For example, this limits
function calls to calls to const functions only when in a const context

You can skip reviewing b4864c7 as it's the exact same commit cherry-picked from #1415 

Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>
@CohenArthur CohenArthur force-pushed the context-stack branch 2 times, most recently from 6ae464a to fa5561e Compare July 28, 2022 15:40
@CohenArthur
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 28, 2022
@bors @CohenArthur
Merge #1415
da7a2ff 
1415: Add generic `StackedContexts<T>` type r=CohenArthur a=CohenArthur



Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>
@bors
Copy link
Contributor

bors bot commented Jul 28, 2022

Build failed:

@CohenArthur
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jul 28, 2022
@bors @CohenArthur
Merge #1415
ae494e7 
1415: Add generic `StackedContexts<T>` type r=CohenArthur a=CohenArthur



Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>
@bors
Copy link
Contributor

bors bot commented Jul 28, 2022

Build failed:

@CohenArthur
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 28, 2022

Build succeeded:

@bors bors bot merged commit 0632b1a into Rust-GCC:master Jul 28, 2022
@CohenArthur CohenArthur deleted the context-stack branch July 29, 2022 14:00
@CohenArthur CohenArthur mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philberty philberty philberty approved these changes

Assignees

@CohenArthur CohenArthur

Labels
cleanup enhancement
Projects
None yet
Milestone
Basic const generics and missing feat...
Development

Successfully merging this pull request may close these issues.
2 participants
@CohenArthur @philberty