Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe: Add checks for union field accesses #1416

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

CohenArthur
Copy link
Member

Addresses #1411

Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits

gcc/rust/checks/errors/rust-unsafe-checker.cc Outdated Show resolved Hide resolved
gcc/rust/checks/errors/rust-unsafe-checker.cc Outdated Show resolved Hide resolved
Co-authored-by: philberty <philip.herron@embecosm.com>
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one LGTM

@CohenArthur
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 28, 2022

Build succeeded:

@bors bors bot merged commit 6d5eb73 into Rust-GCC:master Jul 28, 2022
@CohenArthur CohenArthur deleted the unsafe-union-access branch July 28, 2022 16:24
@CohenArthur CohenArthur mentioned this pull request Jul 29, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants