Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe: Check for unsafe function/method calls #1427

Merged
merged 4 commits into from
Jul 29, 2022
Merged

unsafe: Check for unsafe function/method calls #1427

merged 4 commits into from
Jul 29, 2022

Conversation

CohenArthur
Copy link
Member

Addresses #1411

@CohenArthur CohenArthur mentioned this pull request Jul 29, 2022
Open
11 tasks
@philberty philberty added this to the Const Generics milestone Jul 29, 2022
philberty
philberty approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to mention a missing dg-error on unsafe7.rs testcase. But you got there first.

LGTM

@CohenArthur
testsuite: Calls to transmute are unsafe
df0dd17
@CohenArthur
testsuite: Calls to printf are unsafe
e88a55a
@CohenArthur
mappings: Keep track of extern blocks
b38dee3 
When inserting external items, it's interesting to also be able to
lookup the extern block they were defined in, similarly to impl items.
This is useful to know the ABI or other specifiers of the block the item
has been declared in.
@CohenArthur
unsafe: Report errors on calls to unsafe or extern functions and methods
f742538
@CohenArthur
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 29, 2022

Build succeeded:

@bors bors bot merged commit 8809ee8 into Rust-GCC:master Jul 29, 2022
@CohenArthur CohenArthur deleted the unsafe-function-calls branch July 29, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philberty philberty philberty approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Basic const generics and missing feat...
Development

Successfully merging this pull request may close these issues.
2 participants
@CohenArthur @philberty