[E0061] Refactored argument mismatch error function

[MahadMuhammad]

Argument Mismatch Error-E0061

• Refactored argument mismatch error into one function emit_unexpected_argument_error.
• Changed unexpected argument message to similiar to rustc.
• You can view the same on compiler-explorer:

- unexpected number of arguments x expected y [E0061]
+ this function takes y arguments but x arguments were supplied [E0061]

---

Code Tested:

• rust/compile/func2.rs
• rust/compile/tuple_struct2.rs
• rust/compile/unexpected_arguments.rs

// https://doc.rust-lang.org/error_codes/E0061.html
fn main() {
    fn f(u: i32) {}
    fn T(u: i32, v: i32, w: i32, x: i32, y: i32, z: i32) {}

    f(); // { dg-error "this function takes 1 argument but 0 arguments were supplied" }

    T(1, 2, 3, 4, 5, 6, 7, 8, 9); // { dg-error "this function takes 6 arguments but 9 arguments were supplied" }
}

---

Output:

/gccrs/gcc/testsuite/rust/compile/func2.rs:6:13: error: this function takes 2 arguments but 1 arguments were supplied [E0061]
compiler exited with status 1

/gccrs/gcc/testsuite/rust/compile/tuple_struct2.rs:4:13: error: this function takes 3 arguments but 2 arguments were supplied [E0061]
compiler exited with status 1

/gccrs/gcc/testsuite/rust/compile/unexpected_arguments.rs:6:5: error: this function takes 1 arguments but 0 arguments were supplied [E0061]
/gccrs/gcc/testsuite/rust/compile/unexpected_arguments.rs:7:5: error: this function takes 6 arguments but 9 arguments were supplied [E0061]
compiler exited with status 1

---

gcc/rust/ChangeLog:

* typecheck/rust-tyty-call.cc (emit_unexpected_argument_error): Refactored invalid number of argument into one function. (TypeCheckCallExpr::visit): called refactored function. (TypeCheckMethodCallExpr::check): called refactored function.

gcc/testsuite/ChangeLog:

* rust/compile/func2.rs: updated comment to pass new test cases.
* rust/compile/tuple_struct2.rs: updated comment.
* rust/compile/unexpected_arguments.rs: Added new test.

---

[MahadMuhammad]

• rustc treats 1 as singular while all others numbers as plural.

• You can also test this on compiler-explorer

  • this function takes 1 argument but 0 arguments were supplied
  • this function takes 0 arguments but 1 argument was supplied

Should I also add this?

• Done

[philberty]

LGTM just remove the return statement.

[philberty]

This should be fixed with dg-error.

If not i will take another look when you update the PR. Also take a look at your rust.log output too.