[E0268] break or continue used outside of loop

[MahadMuhammad]

Loop Keyword used outside of loop - E0268

• A loop keyword (break or continue) was used outside of a loop.
• Refactored error description similiar to rustc.

---

Code tested from E0268

// https://doc.rust-lang.org/error_codes/E0268.html
#![allow(unused)]
fn boo() {
    continue; // { dg-error ".continue. outside of a loop" }
    break; // { dg-error ".break. outside of a loop or labeled block" }
}

fn main() {
    boo()
}

---

Output:

➜  gccrs-build gcc/crab1 /home/mahad/Desktop/mahad/gccrs/gcc/testsuite/rust/compile/break_continue_outside_loop.rs
/home/mahad/Desktop/mahad/gccrs/gcc/testsuite/rust/compile/break_continue_outside_loop.rs:4:5: error: ‘continue’ outside of a loop [E0268]
    4 |     continue;       // { dg-error ".continue. outside of a loop"}
      |     ^~~~~~~~
/home/mahad/Desktop/mahad/gccrs/gcc/testsuite/rust/compile/break_continue_outside_loop.rs:5:5: error: ‘break’ outside of a loop or labeled block [E0268]
    5 |     break;          // { dg-error ".break. outside of a loop or labeled block"}
      |     ^~~~~

Analyzing compilation unit

Time variable                                   usr           sys          wall           GGC
 phase parsing                      :   0.00 (  0%)   0.01 (100%)   0.00 (  0%)  8192  (  5%)
 parser (global)                    :   0.00 (  0%)   0.01 (100%)   0.00 (  0%)  8192  (  5%)
 TOTAL                              :   0.00          0.01          0.00          146k
Extra diagnostic checks enabled; compiler may run slowly.
Configure with --enable-checking=release to disable checks.

---

Running testcases:

• gcc/testsuite/rust/compile/break1.rs
• gcc/testsuite/rust/compile/continue1.rs

/home/mahad/Desktop/mahad/gccrs/gcc/testsuite/rust/compile/break1.rs:4:5: error: 'break' outside of a loop or labeled block [E0268]
compiler exited with status 1
PASS: rust/compile/break1.rs  (test for errors, line 4)
PASS: rust/compile/break1.rs (test for excess errors)

/home/mahad/Desktop/mahad/gccrs/gcc/testsuite/rust/compile/continue1.rs:6:9: error: 'continue' outside of a loop [E0268]
compiler exited with status 1
PASS: rust/compile/continue1.rs  (test for errors, line 6)
PASS: rust/compile/continue1.rs (test for excess errors)

---

gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): refactored and call error function.

gcc/testsuite/ChangeLog:

* rust/compile/break1.rs: Modified to pass test case.
* rust/compile/continue1.rs: likewise.
* rust/compile/break_continue_outside_loop.rs: New test.

---

[MahadMuhammad]

Changed error message, similiar to rustc- E0268.

• You can see it on godbolt

[MahadMuhammad]

• rustc 1.49 has error message:

`break` outside of a loop

• But, I updated the message according to rustc nightly version

`break` outside of a loop or labeled block

• You can see difference on the compiler-explorer on the link above.

[MahadMuhammad]

same here.

[CohenArthur]

Looks great! Thank you :)