Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E0599] Failed to resovle method implementation #2571

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

MahadMuhammad
Copy link
Contributor

Use of unresolved method on type - E0599

Added new error message, rich location and error code.

Testcases:


gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Added new error message, rich location and error code.

gcc/testsuite/ChangeLog:

* rust/compile/cfg2.rs: Updated according to new message.
* rust/compile/issue-2139.rs: likewise.
* rust/compile/issue-2190-1.rs: likewise
* rust/compile/method1.rs: likewise

@CohenArthur CohenArthur self-requested a review August 21, 2023 14:55
@CohenArthur CohenArthur added the diagnostic diagnostic static analysis label Aug 21, 2023
gcc/rust/ChangeLog:

	* typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit):
	Added new error message, rich location and error code.

gcc/testsuite/ChangeLog:

	* rust/compile/cfg2.rs: Updated according to new message.
	* rust/compile/issue-2139.rs: likewise.
	* rust/compile/issue-2190-1.rs: likewise.
	* rust/compile/method1.rs: likewise.

Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the new error message looks good :) Thank you!

@CohenArthur CohenArthur added this pull request to the merge queue Sep 8, 2023
Merged via the queue into Rust-GCC:master with commit 139f6c3 Sep 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic diagnostic static analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants