Add basic wrapper over gcc rich_location #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
force-pushed
the
phil/rich-locations-building-block
branch
2 times, most recently
from
bdcd16b
to
1f3991a
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 17, 2021
374: Add basic wrapper over gcc rich_location r=philberty a=philberty Adding rich location will improve our error message diagnostics, this is an initial building block to keep a wrapper over the GCC stuff we call. Addresses: #97 Fixes: #327 Co-authored-by: Philip Herron <philip.herron@embecosm.com>
|
Build failed: |
Adding rich location will improve our error message diagnostics, this is an initial building block to keep a wrapper over the GCC stuff we call. Addresses: #97
This fatal error stops the compiler in its tracks and will mean the Typed HIR dump will not occur limiting how much we can debug errors/bugs in the compiler. Fixes #327
This means we get a single error for the failure but still see the location for each dup.
We are getting an extra emition of an error since the rebase and changes to can_eq.
philberty
force-pushed
the
phil/rich-locations-building-block
branch
from
1f3991a
to
5b8de2b
Compare
|
bors r+ |
|
Build succeeded: |
tschwinge
added a commit
that referenced
this pull request
Sep 23, 2021
tschwinge
added a commit
that referenced
this pull request
Sep 24, 2021
bors bot
added a commit
that referenced
this pull request
Sep 24, 2021
690: A bit of 'RichLocation' C++ tuning [#247], [#97, #374] r=philberty a=tschwinge ... in preparation for a merge from GCC upstream, where we otherwise run into several different build errors. Follow-up to commit ed651fc "Add basic wrapper over gcc rich_location". Co-authored-by: Thomas Schwinge <thomas@codesourcery.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding rich location will improve our error message diagnostics, this is
an initial building block to keep a wrapper over the GCC stuff we call.
Addresses: #97
Fixes: #327