-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate Sample to dasp_sample #689
Conversation
I opened #488 because I needed i24 support, but I ended up rolling my own f32 -> i24 conversion because I didn't need anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think this moves into the direction that @mitchmindtree suggested.
Any advice on how I could verify that the non-Linux code would compile? |
@kawogi you can check the CI of this PR for that. |
There seem to be some build failures for some of the platforms, that seem to be caused by this PR. |
Can someone tell me how I can get IDE support for foreign platforms in VScode? At the moment I'm trying to fix the above problems blindly with rust-analyzer being ignorant about everything. |
Hmmm - is that correct that I have to fix |
Friendly reminder: can I get another run? |
I've re-pushed the button. Sadly, github does not expose an UI option to trust new contributors, even if you just want to trust one. @kawogi would it be possible to file a trivial PR to this repo? Ideally something that might still be useful at least a little. Then you would be auto approved by github. |
Fix some Edition 2021 warnings/errors
catch more unsupported sample formats
I just removed the lossy sample type conversion in asio as |
The failing check is about the recursion depth when compiling Can someone have a look into this so I can check that my changes aren't breaking the test (compiling to |
Is there a way I can help to bring this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for doing this!
This is an attempt to fix #488
In the course of migrating to
dasp_module
I also unlockedi8
,u8
,i32
,u32
,i64
,u64
andf64
. I did not extend this toi24
,u24
,i48
,u48
because I felt there are open question regarding the memory layout.So far I did run the tests for ALSA. I might need some help to adjust the implementation for other platforms.