-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve seek #22
Open
TonalidadeHidrica
wants to merge
18
commits into
RustAudio:master
Choose a base branch
from
TonalidadeHidrica:better-seek
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve seek #22
TonalidadeHidrica
wants to merge
18
commits into
RustAudio:master
from
TonalidadeHidrica:better-seek
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of returning an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
PacketReader:seek_absgp
has several issues:My new implementation,
PacketReader::seek_absgp_new
handles all of those issues above. Also, I provided a new functionfind_end_of_logical_stream
to find the end of a stream within multiple chained streams.I know there are still some issues:
find_next_page
, my newseek_absgp_new
function, andfind_end_of_logical_stream
function intest_find_next_page
,test_seek
, andtest_find_end
, respectively.rustfmt
, so I just kept as it is after I wrote the code. Thus there are even mixed tabs and spaces for indents. It's quite a hard work to do such formatting, so I'd like to do later, maybe right before merging.Other than those tasks, do you have any concerns about this PR? Feel free to tell me and I'll do my best.