-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unmaintained actions-rs/toolchain action in CI workflows #275
Replace unmaintained actions-rs/toolchain action in CI workflows #275
Conversation
Basically all of the `actions-rs/*` actions are unmaintained. See <actions-rs/toolchain#216> for more information. Due to their age they generate several warnings in CI runs. To get rid of some of those warnings the occurrences of `actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`.
Internal compiler error strikes again (https://github.com/RustCrypto/RSA/actions/runs/4442743189/jobs/7799277268):
To me it looks like this is an instance of rust-lang/rust#109199, too. |
@newpavlov it'd probably be good if the minimal-versions action only used nightly to do |
As far as I understand, this particular ICE is fixed in newer versions of rustc nightly, so just re-triggering the jobs that are using nightly might be enough to make the whole workflow pass again. (It obviously does not help with future ICEs, though.) |
Basically all of the
actions-rs/*
actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/RustCrypto/RSA/actions/runs/4347839802:To get rid of some of those warnings the occurrences of
actions-rs/toolchain
are replaced bydtolnay/rust-toolchain
.(Note: There is no occurrence of
actions-rs/cargo
in this workflow, so it does not need to be replaced.)