cms and pkcs7 overlap
#1045
Comments
|
Possibly. The cms crate is more complete with regard to CMS structures. I prefer how ContentInfo is handled there as well (unsurprisingly). The cms crate more consistent with how structures are defined in x509, ocsp, cmpv2 and crmf. The pkcs7 crate may predate x509, which is when lots of stuff was added to der. The pkcs7 crate is mostly SignedData focused. Not sure offhand how much the structures other than ContentInfo differ. |
tarcieri
added a commit
that referenced
this issue
May 13, 2023
This commit adds a deprecation notice to README.md for the `pkcs7` crate announcing `cms` as its official successor. Notably `pkcs7` predates many of the other format-related crates and uses entirely reference-based conventions which we migrated away from in the `x509-cert` crate. `cms` uses the newer conventions, and is more complete as a Cryptographic Message Syntax implementation. We will not be accepting pull requests for `pkcs7` and are leaving its source code for now only to aid in porting functionality not yet present in the `cms` crate. When the next breaking release of `der` occurs, we will delete the `pkcs7` source code from the repository, leaving only the deprecation notice to help assist people migrating. Closes #1045.
|
I added a deprecation notice to Let's use |
tarcieri
added a commit
that referenced
this issue
May 13, 2023
This commit adds a deprecation notice to README.md for the `pkcs7` crate announcing `cms` as its official successor. Notably `pkcs7` predates many of the other format-related crates and uses entirely reference-based conventions which we migrated away from in the `x509-cert` crate. `cms` uses the newer conventions, and is more complete as a Cryptographic Message Syntax implementation. We will not be accepting pull requests for `pkcs7` and are leaving its source code for now only to aid in porting functionality not yet present in the `cms` crate. When the next breaking release of `der` occurs, we will delete the `pkcs7` source code from the repository, leaving only the deprecation notice to help assist people migrating. Closes #1045.
tarcieri
added a commit
that referenced
this issue
May 13, 2023
This commit adds a deprecation notice to README.md for the `pkcs7` crate announcing `cms` as its official successor. Notably `pkcs7` predates many of the other format-related crates and uses entirely reference-based conventions which we migrated away from in the `x509-cert` crate. `cms` uses the newer conventions, and is more complete as a Cryptographic Message Syntax implementation. We will not be accepting pull requests for `pkcs7` and are leaving its source code for now only to aid in porting functionality not yet present in the `cms` crate. When the next breaking release of `der` occurs, we will delete the `pkcs7` source code from the repository, leaving only the deprecation notice to help assist people migrating. Closes #1045.
tarcieri
added a commit
that referenced
this issue
May 13, 2023
This commit adds a deprecation notice to README.md for the `pkcs7` crate announcing `cms` as its official successor. Notably `pkcs7` predates many of the other format-related crates and uses entirely reference-based conventions which we migrated away from in the `x509-cert` crate. `cms` uses the newer conventions, and is more complete as a Cryptographic Message Syntax implementation. We will not be accepting pull requests for `pkcs7` and are leaving its source code for now only to aid in porting functionality not yet present in the `cms` crate. When the next breaking release of `der` occurs, we will delete the `pkcs7` source code from the repository, leaving only the deprecation notice to help assist people migrating. Closes #1045.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
cmsandpkcs7crates seem to have a lot of overlap.Should we pick one to be the place for CMS-related functionality and retire the other?
cc @carl-wallace
The text was updated successfully, but these errors were encountered: