pem-rfc7468: revamp encapsulated length calculation functions #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Estimates upper bound of the length of encoded line-wrapped Base64 with a specified customizable line width and line ending. Also changes the input parameters of `encapsulated_len`, which now accepts the length of the raw input data prior to Base64 encoding, making it significantly less error prone. Together these functions are used to DRY out similar calculations presently occurring in the `der` and `ssh-key` crates. This is a breaking change, so it also bumps the version to v0.6.0-pre.
tarcieri
changed the title
encapsulated_len_wrapped
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimates upper bound of the length of encoded line-wrapped Base64 with a specified customizable line width and line ending.
Also changes the input parameters of
encapsulated_len, which now accepts the length of the raw input data prior to Base64 encoding, making it significantly less error prone.Together these functions are used to DRY out similar calculations presently occurring in the
derandssh-keycrates.This is a breaking change, so it also bumps the version to v0.6.0-pre.