Fix and test min versions build #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
min_versions
branch
from
dd8aa7a
to
35f11e0
Compare
tarcieri
force-pushed
the
min_versions
branch
from
35f11e0
to
0a02028
Compare
|
This isn't going to work with the We can revisit this if the issues around |
|
I think we should keep this issue open since min version build does not work for all crates in this repository. At the very least it should be fixed and checked manually. |
|
@newpavlov it's unfixable without |
|
Ah, I thought it was an issue, not PR. |
|
A tracking issue would probably be good. If things get fixed upstream this would work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.