elliptic-curve: add Generate trait
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tarcieri
force-pushed
the
elliptic-curve/generate
branch
2 times, most recently
from
05d2013
to
1a024bb
Compare
newpavlov
reviewed
Jul 25, 2020
elliptic-curve/src/lib.rs
Outdated
| #[cfg(feature = "rand_core")] | ||
| pub trait Generate { | ||
| /// Generate a random element of this type using the provided [`CryptoRng`] | ||
| fn generate(rng: &mut (impl CryptoRng + RngCore)) -> Self; |
There was a problem hiding this comment.
RngCore is implemented for mutable RNG references, so we can use rng: impl CryptoRng + RngCore here.
Trait for randomly generating types using a `rand_core::CryptoRng`. Potentially useful in trait bounds that need to generate e.g. `Scalar` types.
tarcieri
force-pushed
the
elliptic-curve/generate
branch
from
1a024bb
to
88fd50e
Compare
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 27, 2020
Impls the new trait for random generation added in RustCrypto/traits#220. This can potentially be used to completely replace the `GenerateSecretKey` trait, since that can now be made a conditionally impl'd inherent method on `SecretKey` with where bounds on `Scalar: Generate`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 27, 2020
Impls the new trait for random generation added in RustCrypto/traits#220. This can potentially be used to completely replace the `GenerateSecretKey` trait, since that can now be made a conditionally impl'd inherent method on `SecretKey` with where bounds on `Scalar: Generate`.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 27, 2020
Impls the new trait for random generation added in RustCrypto/traits#220. This can potentially be used to completely replace the `GenerateSecretKey` trait, since that can now be made a conditionally impl'd inherent method on `SecretKey` with where bounds on `Scalar: Generate`.
Merged
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
This enables performing a much more exhaustive set of tests for `no_std` targets, which as of RustCrypto#215 all crates in this repo are fully capable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trait for randomly generating types using a
rand_core::CryptoRng.Potentially useful in trait bounds that need to generate e.g.
Scalartypes.