Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify block-cipher and stream-cipher into cipher #337

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

tarcieri
Copy link
Member

We are now owners of the cipher crate:

https://crates.io/crates/cipher

This commit unifies the existing block-cipher and stream-cipher crates into the cipher crate, placing their code under the cipher::block and cipher::stream modules respectively.

Ideally this means the crate is a drop-in replacement, and all end users need to do is s/block_cipher/cipher::block/ and
s/stream_cipher/cipher::stream to upgrade.

@tarcieri tarcieri force-pushed the unified-cipher-crate branch 2 times, most recently from 6a907ed to b8d86d5 Compare October 15, 2020 15:33
@tarcieri
Copy link
Member Author

tarcieri commented Oct 15, 2020

@newpavlov if this looks good to you, can you add @RustCrypto/traits as owner of the cipher crate?

I can take care of updating all of the respective crates that presently (transitively) depend on block-cipher and stream-cipher.

We are now owners of the `cipher` crate:

https://crates.io/crates/cipher

This commit unifies the existing `block-cipher` and `stream-cipher`
crates into the `cipher` crate, placing their code under the
`cipher::block` and `cipher::stream` modules respectively.

Ideally this means the crate is a drop-in replacement, and all end users
need to do is `s/block_cipher/cipher::block/` and
`s/stream_cipher/cipher::stream` to upgrade.
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this looks good to you, can you add @RustCrypto/traits as owner of the cipher crate?

Done!

@tarcieri
Copy link
Member Author

Awesome, thanks!

@tarcieri tarcieri merged commit 5fcffeb into master Oct 15, 2020
@tarcieri tarcieri deleted the unified-cipher-crate branch October 15, 2020 18:37
tarcieri added a commit to RustCrypto/stream-ciphers that referenced this pull request Oct 16, 2020
This PR replaces all previous usages of the `block-cipher` and
`stream-cipher` crates with the new unified `cipher` crate.

See also: RustCrypto/traits#337
tarcieri added a commit to RustCrypto/stream-ciphers that referenced this pull request Oct 16, 2020
This PR replaces all previous usages of the `block-cipher` and
`stream-cipher` crates with the new unified `cipher` crate.

See also: RustCrypto/traits#337
tarcieri added a commit to RustCrypto/stream-ciphers that referenced this pull request Oct 16, 2020
This PR replaces all previous usages of the `block-cipher` and
`stream-cipher` crates with the new unified `cipher` crate.

See also: RustCrypto/traits#337
dns2utf8 pushed a commit to dns2utf8/traits that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants