zeroize: feature-gate AVX-512 under simd; MSRV 1.60
#1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restores MSRV 1.60 by feature-gating AVX-512 support on x86(_64) targets, which is the only thing which required the previous MSRV of 1.72. Using a generic `simd` name (unlike the previous `aarch64` feature name) allows us to provide more feature-gated SIMD register support in the future without giving architecture-specific targets to each one, while also avoiding MSRV bumps in such cases. When we bump overall MSRV, such support can be moved out from under the feature gate.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores MSRV 1.60 by feature-gating AVX-512 support on x86(_64) targets, which is the only thing which required the previous MSRV of 1.72.
Using a generic
simdname (unlike the previousaarch64feature name) allows us to provide more feature-gated SIMD register support in the future without giving architecture-specific targets to each one, while also avoiding MSRV bumps in such cases.When we bump overall MSRV, such support can be moved out from under the feature gate.