Skip to content

Conversation

leofvo
Copy link
Contributor

@leofvo leofvo commented Dec 12, 2022

No description provided.

@leofvo
Copy link
Contributor Author

leofvo commented Dec 12, 2022

Close #471

@leofvo
Copy link
Contributor Author

leofvo commented Dec 12, 2022

Hey @bee-san, I'm improving our DevOps flow by autodistribute docker image to stay updated with source code.

I will need you to set 2 github secrets if you're OK with that ;)

DOCKER_USERNAME your dockerhub username
DOCKER_PASSWORD your dockerhub token

@leofvo leofvo force-pushed the publish-docker branch 2 times, most recently from d1a92fd to ea37f83 Compare December 12, 2022 09:25
@bee-san
Copy link
Owner

bee-san commented Dec 13, 2022

@leofvo 👋🏻 Thanks so much for all your help! I have some job interviews coming up so I am preparing for them, this is on my todo list

Annoyingly I yanked the crates.io token too accidentally 🙈 So I'll need to add that back in

I might spend a day or two investigating adding Lua support so we can have Nmap scripts too, think about how awesome that'd be!

Equally I am distracted by building https://github.com/bee-san/Ares , lots of things going on 😅

Just wanted to show my appreciation! If you set up a GitHub sponsors I'll sponsor you 👍🏻 <3

@bee-san
Copy link
Owner

bee-san commented Dec 13, 2022

Ok I've added docker read & write perms to the repo with the secrets :D

I am rerunning it, equally I am trying to do the same thing over with the Discord bot at https://github.com/bee-san/discord-bot/blob/main/.github/workflows/docker-release.yml but failing if you were bored enough to fix my mistakes 😂 🙈 (I should also say this needs to run on Arm7, which is why the Dockerfile looks so ugly for that repo)

@bee-san
Copy link
Owner

bee-san commented Dec 13, 2022

Screenshot 2022-12-13 at 11 19 22

Not sure what's going on, I have the password & username set just like in the action 🤔 Maybe GitHub needs a moment to propagate it across all the replicas of whatever secret management system they're using 😂

@leofvo
Copy link
Contributor Author

leofvo commented Dec 13, 2022

Screenshot 2022-12-13 at 11 19 22

Not sure what's going on, I have the password & username set just like in the action thinking Maybe GitHub needs a moment to propagate it across all the replicas of whatever secret management system they're using joy

I think we have to re-run jobs, can you try it ?

@leofvo
Copy link
Contributor Author

leofvo commented Dec 13, 2022

Ok I've added docker read & write perms to the repo with the secrets :D

I am rerunning it, equally I am trying to do the same thing over with the Discord bot at https://github.com/bee-san/discord-bot/blob/main/.github/workflows/docker-release.yml but failing if you were bored enough to fix my mistakes joy see_no_evil (I should also say this needs to run on Arm7, which is why the Dockerfile looks so ugly for that repo)

I can take a look yeah ;)

@leofvo
Copy link
Contributor Author

leofvo commented Dec 13, 2022

Okay I got it...
As said there docker/login-action#29, we can't access env variable from fork. I think this is why... I don't know how to fix it :/

@bee-san
Copy link
Owner

bee-san commented Dec 13, 2022

Okay I got it...
As said there docker/login-action#29, we can't access env variable from fork. I think this is why... I don't know how to fix it :/

Should I just merge and hope it works lol?

@leofvo
Copy link
Contributor Author

leofvo commented Dec 13, 2022

Okay I got it...
As said there docker/login-action#29, we can't access env variable from fork. I think this is why... I don't know how to fix it :/

Should I just merge and hope it works lol?

Ahh, maybe try to allow using secret from fork to run this job and disable after, no ? :D

@bee-san
Copy link
Owner

bee-san commented Dec 13, 2022

Okay I got it...
As said there docker/login-action#29, we can't access env variable from fork. I think this is why... I don't know how to fix it :/

Should I just merge and hope it works lol?

Ahh, maybe try to allow using secret from fork to run this job and disable after, no ? :D

I do not think this is an option 🤔

@leofvo
Copy link
Contributor Author

leofvo commented Dec 13, 2022

Okay I got it...
As said there docker/login-action#29, we can't access env variable from fork. I think this is why... I don't know how to fix it :/

Should I just merge and hope it works lol?

Ahh, maybe try to allow using secret from fork to run this job and disable after, no ? :D

I do not think this is an option thinking

Yeah I can't find it :/
I mean, Dockerfile can be reviewed and github action will be try in production :|

@bee-san bee-san merged commit 5b00fa1 into bee-san:master Dec 20, 2022
@bee-san
Copy link
Owner

bee-san commented Dec 20, 2022

Okay I got it...
As said there docker/login-action#29, we can't access env variable from fork. I think this is why... I don't know how to fix it :/

Should I just merge and hope it works lol?

Ahh, maybe try to allow using secret from fork to run this job and disable after, no ? :D

I do not think this is an option thinking

Yeah I can't find it :/ I mean, Dockerfile can be reviewed and github action will be try in production :|

We'll try in prod!

@bee-san
Copy link
Owner

bee-san commented Dec 23, 2022

Am I right in thinking I need to make a release for this? 👀

@CMNatic
Copy link
Contributor

CMNatic commented Apr 13, 2023

Yeah, looks like it's a problem with secrets. Also, the workflow is using docker. password for the password, I think we need to use docker.token instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants