-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
build and publish docker image in ci #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Close #471 |
550816d
to
7bca8e7
Compare
Hey @bee-san, I'm improving our DevOps flow by autodistribute docker image to stay updated with source code. I will need you to set 2 github secrets if you're OK with that ;) DOCKER_USERNAME your dockerhub username |
d1a92fd
to
ea37f83
Compare
@leofvo 👋🏻 Thanks so much for all your help! I have some job interviews coming up so I am preparing for them, this is on my todo list Annoyingly I yanked the crates.io token too accidentally 🙈 So I'll need to add that back in I might spend a day or two investigating adding Lua support so we can have Nmap scripts too, think about how awesome that'd be! Equally I am distracted by building https://github.com/bee-san/Ares , lots of things going on 😅 Just wanted to show my appreciation! If you set up a GitHub sponsors I'll sponsor you 👍🏻 <3 |
Ok I've added docker read & write perms to the repo with the secrets :D I am rerunning it, equally I am trying to do the same thing over with the Discord bot at https://github.com/bee-san/discord-bot/blob/main/.github/workflows/docker-release.yml but failing if you were bored enough to fix my mistakes 😂 🙈 (I should also say this needs to run on Arm7, which is why the Dockerfile looks so ugly for that repo) |
I can take a look yeah ;) |
e947d74
to
689527a
Compare
Signed-off-by: leofvo <leofvo@proton.me>
689527a
to
01c7037
Compare
Okay I got it... |
Should I just merge and hope it works lol? |
Ahh, maybe try to allow using secret from fork to run this job and disable after, no ? :D |
I do not think this is an option 🤔 |
Yeah I can't find it :/ |
We'll try in prod! |
Am I right in thinking I need to make a release for this? 👀 |
Yeah, looks like it's a problem with secrets. Also, the workflow is using |
No description provided.