rustsec: use Query::crate_scope() as the Default
#544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RustSec Advisory Database contains advisories for both crates and rustc releases, exposing them both programatically. However, most downstream users are interested only in crate advisories. The rustc advisories, which are versioned according to rustc releases as opposed to the corresponding crate versions, may lead to surprising and unexpected false positives if users don't select the appropriate scope. Therefore, `Query::crate_scope()` seems like a more appropriate `Default`. See deps-rs/deps.rs#97 for a real-world example of where this caused unexpected false positives.
tarcieri
changed the title
Query::crate_scope() as the Default.Query::crate_scope() as the Default
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RustSec Advisory Database contains advisories for both crates and rustc releases, exposing them both programatically.
However, most downstream users are interested only in crate advisories. The rustc advisories, which are versioned according to rustc releases as opposed to the corresponding crate versions, may lead to surprising and unexpected false positives if users don't select the appropriate scope.
Therefore,
Query::crate_scope()seems like a more appropriateDefault.See deps-rs/deps.rs#97 for a real-world example of where this caused unexpected false positives.