Reorganize test cases #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashfurrow
reviewed
Nov 28, 2016
| @@ -91,6 +105,10 @@ class ActionTests: QuickSpec { | |||
| next(20, false), | |||
| ]) | |||
| } | |||
|
|
|||
| it("executes twice") { | |||
| XCTAssertEqual(executionObservables.events.count, 2) | |||
There was a problem hiding this comment.
Since the tests use Quick/Nimble, I think using a Nimble matcher instead of XCTAsserts might make sense. Something like expect(executionObservables) == 2. What do you think?
There was a problem hiding this comment.
Yes, we can use Nimble matchers here. I used XCTAssertEqual in other places for matching Recorded<Event<T>>, which is provided in RxTests, but other than that, Nimble matchers might be better choice.
I'll replace the matchers that can be replaced by Nimble matchers.
|
@ashfurrow Thank you for reviewing. I've just replaced the matchers in 1b816f2! |
ashfurrow
approved these changes
Nov 28, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most test cases that I added in #56 overlap existing test cases, but they're written in different way. The new tests check logic on the virtual time. IMHO, the new test method is more appropriate for testing Rx library, so I would like to replace the old tests by the new tests.