-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CompositeStepper #5
Add CompositeStepper #5
Conversation
80442ef
to
88e3466
Compare
Now that the subscriptions are flatten in the Coordinator (branch develop), do you still want to introduce a CompositeStepper ? If not, I will cancel this PR. Thx. |
@twittemb I will test this again by today. |
…RxFlow into composite-stepper
I am reviewing / testing your work. I will keep you in touch. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 3 remarks:
- please rebase your branch on the current develop because I just made a fix that allows your code to work
- CompositeStepper is defined 2 times
- Rename your PR to remove [WIP]
After that we should be good to go
@@ -30,8 +27,36 @@ public class OneStepper: Stepper { | |||
} | |||
} | |||
|
|||
// A Stepper that combines multiple steppers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CompositeStepper is defined 2 times
…RxFlow into composite-stepper # Conflicts: # RxFlow/Stepper.swift
Thanks @dangthaison91 |
For some situation, I have both VM and ViewController act as Stepper. Navigation will be driven by business logic from VM and presentation logic from ViewController.
CompositeStepper
will help to combine multiple Steppers.This PR is WIP: