Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with next version of ggplot2 #20

Closed
thomasp85 opened this issue Oct 10, 2022 · 2 comments
Closed

Issues with next version of ggplot2 #20

thomasp85 opened this issue Oct 10, 2022 · 2 comments

Comments

@thomasp85
Copy link

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that the issues are due to our switch to using the linewidth aesthetic for stroke width instead of size. Please see https://www.tidyverse.org/blog/2022/08/ggplot2-3-4-0-size-to-linewidth/ for more info on this.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards
Thomas

@Ryo-N7
Copy link
Owner

Ryo-N7 commented Oct 11, 2022

understood, thank you for notifying me

yep, i see the problems:
linewidth-size

allrighty, will get a fix on CRAN soon

@Ryo-N7
Copy link
Owner

Ryo-N7 commented Oct 11, 2022

Prepare for release:

  • Check current CRAN check results
  • Update NEWS.md
  • devtools::build_readme()
  • urlchecker::url_check()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • rhub::check_for_cran()
  • rhub::check(platform = 'ubuntu-rchk')
  • rhub::check_with_sanitizers()
  • revdepcheck::cloud_check()
  • Update cran-comments.md

Submit to CRAN >>> (when ggplot2 is ready, end of October):

  • usethis::use_version('patch')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

Accepted 🎉

  • usethis::use_github_release()
  • usethis::use_dev_version()

Ryo-N7 added a commit that referenced this issue Oct 11, 2022
Ryo-N7 added a commit that referenced this issue Nov 17, 2022
- fix tests
- rerun pkgdown
- update NEWS.md and cran-comments

closes #20
@Ryo-N7 Ryo-N7 closed this as completed in 35bbf40 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants