update to php8 #39
update to php8 #39
Conversation
composer.json
Outdated
| @@ -10,12 +10,12 @@ | |||
| "homepage": "https://github.com/S1lentium" | |||
| }], | |||
| "require": { | |||
| "php": ">=5.4.0", | |||
| "php": ">=8.0", | |||
There was a problem hiding this comment.
This needs to be ^8.0 so it does not support e.g. php15
There was a problem hiding this comment.
I don't see this fixed.
The other thing is that this package is not maintained so this won't get merged anytime soon I believe
There was a problem hiding this comment.
I see now my push was rejected due to privacy settings on my email address 🤦🏻♂️ anyhoo i pushed this time around 😛 see 6d0556c
There was a problem hiding this comment.
why do you say this package is not maintained @S1lentium pushed some changes to this package in june?
|
@digibeuk Thank you for PR. Unfortunately, at the moment I don't have enough time to support and check PRs. I hope this commit will not break the dependence on older versions of PHP. I'll tag this commit a bit later |
this PR updates the codebase to be compatible with php8, after this we can start to use php8 features like type hints etc.
fixes : #38