This repository has been archived by the owner on Feb 3, 2020. It is now read-only.
Issue/100 cleanup #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Symbolic write() gets confused with the templated write otherwise. Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
| uint64_t getHostAddress(uint64_t address, AddressType addressType = VirtualAddress) const; | ||
|
|
||
| /** Read memory to buffer, concretize if necessary */ | ||
|
|
||
| /// | ||
| /// \brief read reads data from memory |
There was a problem hiding this comment.
I don’t think you need to include the method name at the start of each comment, it reads a bit funny. It’s probably enough to say “\brief Read data from memory” because we know what method is being documented.
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
vitalych
force-pushed
the
issue/100-cleanup
branch
from
4d76603
to
cbdfee5
Compare
Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>
vitalych
force-pushed
the
issue/100-cleanup
branch
from
6b14eae
to
3ca67a1
Compare
adrianherrera
approved these changes
Feb 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.