Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding dependencies to setup.cfg #65

Closed
wants to merge 3 commits into from

Conversation

holtgrewe
Copy link
Contributor

No description provided.

@davmlaw
Copy link
Contributor

davmlaw commented Nov 9, 2023

I think those are only needed for the data generation? So would just force unecessary libs on the majority who just want the client?

Adds more weight to idea that we should split the data into own package though as per #64

@holtgrewe
Copy link
Contributor Author

That is correct. I agree, an alternative option would be to have a build "feature" in the package, enabled by the availability of these packages.

@davmlaw
Copy link
Contributor

davmlaw commented Nov 13, 2023

I took your changes to setup and added them to a requirements.txt in the generate data directory - thanks for collecting what we needed to run things

I think the package optional features would only make sense if we distributed the generate scripts with the package which I dont' really want to do

@davmlaw davmlaw closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants