Use session to manage redirect location #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dylanpivo
commented
Jul 10, 2024
dylanpivo
commented
- Added a context_processor to the flask app to keep track of the "active_page_url" using the session.
- When returning from identity service, use the "active_page_url" session variable to redirect back to the active page.
marksparkza
reviewed
Jul 26, 2024
odp/ui/client.py
Outdated
| @@ -190,7 +190,9 @@ def _logged_in(self): | |||
|
|
|||
| login_user(localuser) | |||
|
|
|||
| return redirect(url_for('home.index')) | |||
| active_page = session['active_page_url'] if 'active_page_url' in session else url_for('home.index') | |||
There was a problem hiding this comment.
The RHS can be shortened to session.get('active_page_url') or url_for('home.index')
|
Thanks for this - a very useful addition to the library. I've just added one suggestion to make it slightly more succinct. |
dylanpivo
force-pushed
the
login_redirect
branch
from
ab61a3d
to
824d910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.