Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net6 #494

Closed
wants to merge 7 commits into from
Closed

Net6 #494

wants to merge 7 commits into from

Conversation

wtorricos
Copy link

@wtorricos wtorricos commented Dec 13, 2021

Update the minimal and the default templates to .net6 as well as the template solution.

Note: Travis and Azure DevOps tasks are yelling that the version of .Net is not the correct one. I updated all the configurations that I found in the repository so I'm thinking it's something that needs to be updated directly in Travis and Azure. I'm going to need someone to help me do that.

@theimowski
Copy link
Member

For Travis, Linux build succeeded: https://app.travis-ci.com/github/SAFE-Stack/SAFE-template/jobs/551883475, it's just mac build failing: https://app.travis-ci.com/github/SAFE-Stack/SAFE-template/jobs/551883476 - logs show mac is trying to download a file from https://dotnetcli.azureedge.net/dotnet/Sdk/6.0/dotnet-sdk-6.0-osx-x64.pkg which doesn't exist. I'd try specifying whole SDK version 6.0.101 in travis.yml.

For Azure Pipelines, someone from Compositional IT would need to take a look @isaacabraham

Walter Torricos added 2 commits December 16, 2021 19:29
# Conflicts:
#	Content/default/.config/dotnet-tools.json
#	paket.lock
@theimowski
Copy link
Member

@isaacabraham do you have any update on Azure Pipelines configuration here?

@theimowski theimowski mentioned this pull request Jan 28, 2022
@theimowski
Copy link
Member

SAFE-Stack/docs#249 talks about why want to wait for SDK 6.0.200 to be released

@wtorricos
Copy link
Author

Thank you for the update.

@tforkmann
Copy link

Hi there,

you could now use the Saturn prerelease version.
It now supports .NET6.

Cheers!

@isaacabraham
Copy link
Member

@theimowski I'm just looking into this - not sure what's happened here because builds do seem to be running on some occasions.

@teknikal-wizard
Copy link
Collaborator

Hi all! @isaacabraham and I have been trying to work out why devops is failing. Paket restore fails but we can't see why it is happening. It is almost certainly a build host issue as it is passing linux + macos on Travis, and builds fine on our local Windows machines. It is just the Devops ubuntu host that is acting strangely.

@forki Isaac suggested I tag you in case you might be able to provide some insight.

@tforkmann I made a branch from this PR to include Saturn prerelease if you want to give it a go, works fine other than this failing devops issue - #506

@teknikal-wizard
Copy link
Collaborator

Good news! Thanks to @olivercoad we have fixed the build over in #506 . @tico321 , would you like to merge that branch into this one and then I'll abandon my PR. Cheers :)

@wtorricos
Copy link
Author

wtorricos commented Mar 18, 2022

@Ryan-Palmer-CIT that's great!! And I see that you have all the changes required for the minimal and the default template, so I don't see a reason not to drop mine? or do I have some changes that you need?
Also, your branch comes from the CompositionalIT repo and since it's not a SAFE-Template branch it's going to be harder to merge it.

@teknikal-wizard
Copy link
Collaborator

@tico321 yeah we can take mine, that's fine. Just didn't want to pinch your contribution! Thanks for getting us 90% of the way :)

@wtorricos wtorricos closed this Mar 18, 2022
@wtorricos wtorricos deleted the net6 branch March 18, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants