Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process MRIs on GAE #378

Merged
merged 41 commits into from
May 3, 2024
Merged

Process MRIs on GAE #378

merged 41 commits into from
May 3, 2024

Conversation

stefpiatek
Copy link
Contributor

@stefpiatek stefpiatek commented Apr 22, 2024

Tags uses for MS-PINPOINT and prostate MRI projects.

fixes #368

Also some fixes during running:

  • Need to add our services to no-proxy list for the REST requests to work
  • use regex for manufacturer matching and move manufacturer overrides into separate subdir so that its easier to see that they're a different thing
  • Refactored interation with database to be in the base uploader class, so that we don't have to remember to do this when we bring in a new data item (and we don't have to test it each time we do it)
  • Tweaking of logging levels
  • bit more removal of EHR
  • simplified anon processing incoming data to have a top level try catch, so that we if there was a problem reading the data it'll discard
  • series descriptions can be none, so allow for that

Copy link
Contributor

@jstutters jstutters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefpiatek, looks good to me. I've requested a few extra tags that we often use during the image quality control process. Hard to tell if we've covered every required tag until we convert the whole dataset.

projects/configs/tag-operations/mri.yaml Outdated Show resolved Hide resolved
#Scanner
y 0018,0087:FieldStrength
y 0008,0070:Manufacturer
y 0008,1090:Model
y 0018,1020:Software

#Sequence
y 0020,0012:AcquisitionNumber
0020,0011:SeriesNumber
0008,0031:SeriesTime
0008,0032:AcquisitionTime
y 0018,1030:ProtocolName
y 0008,103e:SeriesDescription
y 0008,1160:ReferencedFrameNumber
y 0018,0020:ScanningSequence
y 0018,0021:SequenceVariant
y 0018,0023:MRAcquisitionType
y 0018,0024:SequenceName
y 0018,0050:SliceThickness
y 0018,0094:PhaseFOV
y 0018,1314:FlipAngle
y 0018,0080:RepetitionTime
y 0018,0081:EchoTime
y 0018,0091:EchoTrainLength
y 0018,0083:NumberOfAverages
y 0018,1250:ReceiveCoilName
y 0018,1251:TransmitCoilName
y 0018,1316:SAR

#Siemens Proprietary
0051,100C:FieldOfView
0051,100a:TimeOfAcquisition
0051,100D:SlicePosition
y 0021,1156:Pat
y 0029,1010:SiemensCSA
0021,1019:SiemensCSA (? SW > X50)

#Scaling tags
y 0040,9225:RealWorldValueSlope
y 0040,9224:RealWorldValueIntercept
y 0028,1052:RescaleIntercept
y 0028,1053:RescaleSlope
y 2005,100E:ScaleSlope - Philips Proprietary
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.61%. Comparing base (fc8e962) to head (7d004d0).

Files Patch % Lines
pixl_core/src/core/uploader/base.py 91.66% 1 Missing ⚠️
...l_core/tests/project_config/test_project_config.py 85.71% 1 Missing ⚠️
pixl_export/src/pixl_export/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   82.97%   80.61%   -2.36%     
==========================================
  Files          79       76       -3     
  Lines        3259     3085     -174     
==========================================
- Hits         2704     2487     -217     
- Misses        555      598      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefpiatek stefpiatek marked this pull request as ready for review May 2, 2024 08:15
@stefpiatek stefpiatek requested a review from a team May 2, 2024 08:21
@stefpiatek stefpiatek changed the title Add basic config for MRI testing Process MRIs on GAE May 2, 2024
Copy link
Contributor

@jeremyestein jeremyestein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; nothing here is intended to hold up merging if you need to get it in today. I'm not able to give an opinion on the specific tags referenced here.

Co-authored-by: Jeremy Stein <j.stein@ucl.ac.uk>
@stefpiatek
Copy link
Contributor Author

Looks good; nothing here is intended to hold up merging if you need to get it in today. I'm not able to give an opinion on the specific tags referenced here.

Thanks! I'll wait for a post-merge review from @HChughtai when he's back before we set off the final export for ms-pinpoint

@stefpiatek stefpiatek enabled auto-merge (squash) May 3, 2024 16:56
@stefpiatek stefpiatek merged commit ac4b9ad into main May 3, 2024
10 checks passed
@stefpiatek stefpiatek deleted the stef/mri-anon-check branch May 3, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants