-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process MRIs on GAE #378
Process MRIs on GAE #378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stefpiatek, looks good to me. I've requested a few extra tags that we often use during the image quality control process. Hard to tell if we've covered every required tag until we convert the whole dataset.
#Scanner y 0018,0087:FieldStrength y 0008,0070:Manufacturer y 0008,1090:Model y 0018,1020:Software #Sequence y 0020,0012:AcquisitionNumber 0020,0011:SeriesNumber 0008,0031:SeriesTime 0008,0032:AcquisitionTime y 0018,1030:ProtocolName y 0008,103e:SeriesDescription y 0008,1160:ReferencedFrameNumber y 0018,0020:ScanningSequence y 0018,0021:SequenceVariant y 0018,0023:MRAcquisitionType y 0018,0024:SequenceName y 0018,0050:SliceThickness y 0018,0094:PhaseFOV y 0018,1314:FlipAngle y 0018,0080:RepetitionTime y 0018,0081:EchoTime y 0018,0091:EchoTrainLength y 0018,0083:NumberOfAverages y 0018,1250:ReceiveCoilName y 0018,1251:TransmitCoilName y 0018,1316:SAR #Siemens Proprietary 0051,100C:FieldOfView 0051,100a:TimeOfAcquisition 0051,100D:SlicePosition y 0021,1156:Pat y 0029,1010:SiemensCSA 0021,1019:SiemensCSA (? SW > X50) #Scaling tags y 0040,9225:RealWorldValueSlope y 0040,9224:RealWorldValueIntercept y 0028,1052:RescaleIntercept y 0028,1053:RescaleSlope y 2005,100E:ScaleSlope - Philips Proprietary
# Conflicts: # pixl_core/src/core/uploader/_dicomweb.py
Approval for acquisition date: SAFEHR-data/the-rolling-skeleton#223 (comment)
# Conflicts: # cli/README.md
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 82.97% 80.61% -2.36%
==========================================
Files 79 76 -3
Lines 3259 3085 -174
==========================================
- Hits 2704 2487 -217
- Misses 555 598 +43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; nothing here is intended to hold up merging if you need to get it in today. I'm not able to give an opinion on the specific tags referenced here.
projects/configs/tag-operations/manufacturer-overrides/mri-diffusion.yaml
Show resolved
Hide resolved
Co-authored-by: Jeremy Stein <j.stein@ucl.ac.uk>
Thanks! I'll wait for a post-merge review from @HChughtai when he's back before we set off the final export for ms-pinpoint |
Tags uses for MS-PINPOINT and prostate MRI projects.
fixes #368
Also some fixes during running: