Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include project_slug in Image PIXL database queries #380

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

milanmlft
Copy link
Member

@milanmlft milanmlft commented Apr 25, 2024

This should allow running multiple projects with the same or overlapping studies without having to
tear down and rebuild the entire setup.

Necessary for #379.

Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does work, but also the Extract table has that data so we're at least a bit more normalised

cli/src/pixl_cli/_database.py Outdated Show resolved Hide resolved
pixl_core/src/core/db/models.py Outdated Show resolved Hide resolved
cli/src/pixl_cli/_database.py Outdated Show resolved Hide resolved
pixl_dcmd/src/pixl_dcmd/_database.py Outdated Show resolved Hide resolved
This should avoid multiple matches when there are multiple projects
using the same images.
@milanmlft milanmlft force-pushed the milanmlft/query-project-name branch from 90be346 to 096bb2a Compare April 25, 2024 16:35
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

pixl_dcmd/src/pixl_dcmd/_database.py Outdated Show resolved Hide resolved
pixl_dcmd/src/pixl_dcmd/_database.py Show resolved Hide resolved
@milanmlft milanmlft enabled auto-merge (squash) April 25, 2024 16:45
@milanmlft milanmlft merged commit 2f5b307 into main Apr 25, 2024
8 checks passed
@milanmlft milanmlft deleted the milanmlft/query-project-name branch April 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants