feat: replace hashed_id with pseudo study uid #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing imaging and system tests sys tests - due to expecting a predetermined folder name based on hashing algorithm img tests - internal errors, unclear
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 83.17% 83.38% +0.21%
==========================================
Files 80 80
Lines 3280 3304 +24
==========================================
+ Hits 2728 2755 +27
+ Misses 552 549 -3 ☔ View full report in Codecov by Sentry. |
stefpiatek
reviewed
May 3, 2024
stefpiatek
approved these changes
May 3, 2024
pixl_imaging/alembic/versions/cb5ee12a6e20_replace_hashed_id_with_pseudo_study_uid.py
Outdated
Show resolved
Hide resolved
jeremyestein
reviewed
May 7, 2024
Co-authored-by: Stef Piatek <s.piatek@ucl.ac.uk>
…nto peshence/250-pseudo-study-uid
Co-authored-by: Stef Piatek <s.piatek@ucl.ac.uk>
Co-authored-by: Stef Piatek <s.piatek@ucl.ac.uk>
…nto peshence/250-pseudo-study-uid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace linking variable
from: PatientID=hash(PatientID+AccesseionNumber)
to: StudyInstanceUID=generate_uid()
Database is queried to check if a UID was already assigned to this image (identified by patient id and accession number for now, but to be switched to StudyUID once OMOP ES starts serving that)