Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[cli]: only export linker information for processed images #403

Merged
merged 7 commits into from
May 29, 2024

Conversation

peshence
Copy link
Contributor

@peshence peshence commented May 16, 2024

attempt at solving the second definition of done cirteria, closes https://github.com/UCLH-Foundry/the-rolling-skeleton/issues/250

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.23%. Comparing base (b8c6b83) to head (b527c45).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   83.38%   83.23%   -0.15%     
==========================================
  Files          80       78       -2     
  Lines        3304     3257      -47     
==========================================
- Hits         2755     2711      -44     
+ Misses        549      546       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for finishing this off 🎉

Some small suggestions

cli/src/pixl_cli/_database.py Outdated Show resolved Hide resolved
cli/src/pixl_cli/_database.py Show resolved Hide resolved
@stefpiatek stefpiatek merged commit 3a5d6eb into main May 29, 2024
10 checks passed
@stefpiatek stefpiatek deleted the peshence/250-only-link-processed-images branch May 29, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants