Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC datetimes for CSV input #412

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Conversation

stefpiatek
Copy link
Contributor

@stefpiatek stefpiatek commented Jun 14, 2024

May as well use ISO compliant dates and datetimes, plus some extra changes around tests to tidy them up

@stefpiatek stefpiatek requested a review from a team June 14, 2024 12:42
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (3303ffa) to head (668f333).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   83.24%   83.26%   +0.01%     
==========================================
  Files          78       78              
  Lines        3265     3268       +3     
==========================================
+ Hits         2718     2721       +3     
  Misses        547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefpiatek stefpiatek merged commit 1c356f2 into main Jun 19, 2024
10 checks passed
@stefpiatek stefpiatek deleted the stef/csv-uses-utc-datetimes branch June 19, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants