Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of Assertions check should come after status check #190

Closed
thejuan opened this issue Apr 21, 2017 · 1 comment
Closed

Number of Assertions check should come after status check #190

thejuan opened this issue Apr 21, 2017 · 1 comment

Comments

@thejuan
Copy link

thejuan commented Apr 21, 2017

When a failed response is returned as part of sDP initoated SSO there are no assertions and the check for assertions returns the message "SAML Response must contain 1 assertion" but the real issue is the status is not success.
@pitbulk
Copy link
Contributor

pitbulk commented Apr 21, 2017

I think that your proposal makes sense. Do you want to contribute with a PR?
(maybe some unit test need to be updated too)

thejuan added a commit to thejuan/python-saml that referenced this issue Apr 21, 2017
@thejuan
SAML-Toolkits#190 Checking the status of response before assertion count
2b5091c 
Failed Responses don't have assertions and the error hides that the
status is not success
thejuan added a commit to thejuan/python-saml that referenced this issue Apr 21, 2017
@thejuan
SAML-Toolkits#190 Checking the status of response before assertion count
b670d9e 
Failed Responses don't have assertions and the error hides that the
status is not success
thejuan added a commit to thejuan/python-saml that referenced this issue Apr 21, 2017
@thejuan
SAML-Toolkits#190 Complying to pep8
ba9fdfe
@pitbulk pitbulk closed this as completed May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thejuan @pitbulk