-
-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Key Rollover management #389
Conversation
pitbulk
commented
Apr 19, 2017
•
edited
Loading
edited
- Be able to register future SP x509cert on the settings and publish it on SP metadata.
- Be able to register more than 1 Identity Provider x509cert, linked with an specific use (signing or encryption.
- Allow metadata to be retrieved from source containing data of multiple entities.
- Adapt IdP XML metadata parser to take care of multiple IdP certtificates and be able to inject the data obtained on the settings.
…ith an specific use (signing or encryption.
…for multiple entities
…tes and be able to inject the data obtained on the settings.
I think parsing metadata.xml has been break when this one contain more than one SingleSignOnService meta. For example if you have those meta
and you set follow setting
the Perhaps because on this line https://github.com/onelogin/ruby-saml/pull/389/files#diff-224905527907deba9ffd52ff7ab83308R55 passing options is missing ? |
I will review and create more tests |
I'm looking for these features in the java-saml toolkit, any plans to implement them there too in near future? |
I plan to add that functionality to Python and Java too. But there is no estimation on when I gonna be able to start that task. |
@skyporter I think now should be working, thanks for reporting that. have you found any other issue? |
@pitbulk thank you, I had test the branch and it's work fine. I have another issue, but I don't know if it's related to this branch or not (I can't test with the master branch since I have a multi organization metadata). |
and IdpMetadataParser#parse_remote_to_hash. Having the parsed metadata as Hash may be useful for configuring omniauth-saml, for instance.
Implement IdpMetadataParser#parse_to_hash
We added 2 new methods (required by omniauth). [ty @tosch] @vincentwoo @AngelicaS @demonmind @erlingwl @davelooi @tomilaine @skyporter |
This code is broken. You updated the "validate_signature" method to handle the cert_multi, but you never updated the "validate(collect_errors)" method to pass validations when idp_cert_multi exists but the others do not. I'll make a PR right now to fix. But this is the code that needs updating: It needs an or statement for the idp_cert_multi settings. |