Memoize validate result for is_valid? as validate is destructive.

[bmo]

See Issue #60

[bmo]

Folks, not sure what to do here -- the pull request breaks a test; this broken test incrementally changes attributes on the object until the test passes, which I suppose could be a use case for the object, however not one that I would have anticipated.

The patch is meant to address the case of is_valid? being invoked again on the same object after is_valid was calculated to be true. There is no current test for that, however it is a use case we encountered (a logging statement with response.is_valid? was inserted ahead of a 2nd invocation, the logging one succeeded, the 2nd raised an exception (NoMethodError: undefined method `text' for nil:NilClass in xml_security) , and it took a while to understand why.

A much better means to resolve the situation would be to not have XMLSecurity::SignedDocument#validate_doc perform element.remove on at least two pieces of the document.

[stouset]

I think PR #63 satisfies this issue better. Rather than memoizing, it prevents the document from being changed by validation. Please let me know if I've misunderstood something and I'll be happy to reopen.

[bmo]

That is a much better way to do it, yes, thanks!

On Thu, Jan 31, 2013 at 11:39 AM, Stephen Touset
notifications@github.comwrote:

I think PR #63 https://github.com/onelogin/ruby-saml/issues/63satisfies this issue better. Rather than memoizing, it prevents the
document from being changed by validation. Please let me know if I've
misunderstood something and I'll be happy to reopen.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/61#issuecomment-12961448.

e: bmoran@onehub.com
p: +1 206 390 4376

Onehub, Inc.
www.onehub.com