Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node params #53

Merged
merged 1 commit into from
May 30, 2023
Merged

feat: add node params #53

merged 1 commit into from
May 30, 2023

Conversation

mattkb
Copy link
Contributor

@mattkb mattkb commented May 30, 2023

Description

add keys

  • BlockReward
  • Baseline
  • AnnualPercentageYield
  • HalvingPeriod
  • AdjustmentPeriod

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mattkb mattkb changed the base branch from main to develop May 30, 2023 10:59
@mattkb mattkb merged commit 3a423e5 into develop May 30, 2023
mattkb added a commit that referenced this pull request Jun 9, 2023
@mattkb mattkb deleted the matt/add-node-params branch August 25, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants