Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Filters #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Default Filters #16

wants to merge 4 commits into from

Conversation

carlonnheim
Copy link

Hi @schiwekM,

First of all, thanks for this great repository. By far the best source of reference for FE on oData v4!

I would suggest to add samples regarding Default Filters, documented here?

I have added one in this PR. Notably the Default Filters are not working in combination with views (I have disabled that in the PR, if you turn that back on, the app will not load).

I have raised that as a support incident too with number 183769 / 2023, in case you are engaged in that channel too.

Thanks in advance!
//Carl

@cla-assistant
Copy link

cla-assistant bot commented Mar 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ carlonnheim
❌ Carl Önnheim


Carl Önnheim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant
Copy link

cla-assistant bot commented Mar 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Carl Önnheim seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -119,7 +120,7 @@
}
},
"initialLoad": true,
"views": {
"XviewsX": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here, but having both active at the same time crashes the app.

@schiwekM
Copy link
Contributor

schiwekM commented Apr 6, 2023

Hi @carlonnheim,
thanks for the hint. I will pick it up and have a look. As I have a lot to do right now, I will probably work on it in May.

Hope that is fine & BR,
Marten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants