Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge solutions #14

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Challenge solutions #14

wants to merge 15 commits into from

Conversation

Caisi
Copy link

@Caisi Caisi commented Jun 11, 2022

Solution of week 1 of SAP Community Code Challenge UI5.

@cla-assistant
Copy link

cla-assistant bot commented Jun 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Caisi
❌ nicogeburek


nicogeburek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant
Copy link

cla-assistant bot commented Jun 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@nicoschoenteich nicoschoenteich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Caisi, thanks a lot for your submission! We had some issues with the package-lock.json. Can delete your package-lock.json? This should make the test also pass here in the GitHub action. Thanks!

Fixed:
- removed package-lock.json
remove package-lock.json
@Caisi
Copy link
Author

Caisi commented Jun 11, 2022

Hi @Caisi, thanks a lot for your submission! We had some issues with the package-lock.json. Can delete your package-lock.json? This should make the test also pass here in the GitHub action. Thanks!

Hi @nicogeburek, I deleted it. Hope it works now.

Caisi

@nicoschoenteich
Copy link
Contributor

Hi @Caisi , we found and fixed the real issue which was causing the action to fail. Fetching the upstream should update this PR and make the action succeed.

@Caisi
Copy link
Author

Caisi commented Jun 13, 2022

Hi @nicogeburek ,

I've fetched the upstream, but there is an error with npm install. Could you advise how to proceed?

Best regards,
Vladimir

@nicoschoenteich
Copy link
Contributor

Hi @Caisi, sorry about that, it's failing because you are missing the package-lock.json, because I told you to delete it... 🫠 You can run npm install locally again, which should put the file back in place and then push the changes.

@nicoschoenteich
Copy link
Contributor

Hi @Caisi, yep, we finally got it. Thanks for your patience and sorry for the back and forth!

@Caisi
Copy link
Author

Caisi commented Jun 14, 2022

Hi @nicogeburek, that is just great. Thanks for your support!

@nicoschoenteich
Copy link
Contributor

Good job!

@Caisi Caisi changed the title week1 Challenge solutions Jun 16, 2022
@nicoschoenteich
Copy link
Contributor

Hi @Caisi, good job! We will add a new test file on Wednesday ✅

@Caisi
Copy link
Author

Caisi commented Jun 27, 2022

Hi @nicogeburek, thanks and looking forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants