Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCAT] Add new object type Data Category (DCAT) #615

Merged
merged 16 commits into from
Jun 20, 2024

Conversation

C5314720
Copy link
Contributor

No description provided.

@albertmink albertmink added the new-object This is a new object type added to AFF label May 27, 2024
@albertmink
Copy link
Contributor

Thanks, @C5314720.
Is sensitivityLevel an arbitrary char[1] or is there a limited choice, say 'A', 'B' or 'C'. If so, consider an enum (which will be rendered as a dropDown).

@C5314720
Copy link
Contributor Author

Thanks, @C5314720. Is sensitivityLevel an arbitrary char[1] or is there a limited choice, say 'A', 'B' or 'C'. If so, consider an enum (which will be rendered as a dropDown).

Got confirmation and changed type to enum.

@albertmink albertmink requested a review from a team June 7, 2024 07:39
Copy link
Contributor

@albertmink albertmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Markus1812 Markus1812 merged commit 1aea6b7 into SAP:main Jun 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-object This is a new object type added to AFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants