Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSDF] Add new object type DSFD (abapGit#6948) #623

Merged
merged 5 commits into from
Jul 22, 2024
Merged

[DSDF] Add new object type DSFD (abapGit#6948) #623

merged 5 commits into from
Jul 22, 2024

Conversation

fvalves
Copy link
Contributor

@fvalves fvalves commented Jun 18, 2024

Added directory for new object type DSFD (abapGit#6948)

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Jun 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Jun 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I505300 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@schneidermic0 schneidermic0 mentioned this pull request Jun 18, 2024
Closed
@fvalves
Copy link
Contributor Author

fvalves commented Jun 19, 2024

Hi @schneidermic0 , I've added the corrections analogous to the DRAS ones here as well.

schneidermic0
schneidermic0 reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good to me. Maybe, just the header needs to be changed if DSFD have not supported ABAP language version "keyUser", yet.

file-formats/dsfd/type/zif_aff_dsfd_v1.intf.abap Show resolved Hide resolved
@albertmink albertmink added the new-object This is a new object type added to AFF label Jun 20, 2024
@mbtools mbtools mentioned this pull request Jul 10, 2024
Merged
@schneidermic0 schneidermic0 changed the title Add new object type DSFD (abapGit#6948) [DSDF] Add new object type DSFD (abapGit#6948) Jul 22, 2024
schneidermic0
schneidermic0 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fvalves.

Looks good to me.

@schneidermic0 schneidermic0 merged commit 4d9224c into SAP:main Jul 22, 2024
9 checks passed
@schneidermic0
Copy link
Contributor

Welcome as contributor, @fvalves 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
new-object This is a new object type added to AFF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fvalves @schneidermic0 @albertmink @wurzka